Issue 95 #112
Merged
Issue 95 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callout to get states and counties. Merge state and county list. moved merge logic to counties method, dont care much for reusability right now I dont think. Make class models' properties strings due to dumb leading 0s from geo api.
… knows if itll work)
…tool into main Conflicts: rules-engine/pyproject.toml
jkwan2011
approved these changes
Jan 3, 2024
alanisaac
approved these changes
May 22, 2024
AdamFinkle
pushed a commit
to AdamFinkle/home-energy-analysis-tool
that referenced
this pull request
May 22, 2024
* Copy over function for reading csv. Callout to get states and counties. Merge state and county list. moved merge logic to counties method, dont care much for reusability right now I dont think. Make class models' properties strings due to dumb leading 0s from geo api. * Some house cleaning * Clean imports. Change output file path & wrtie row to file(maybe. who knows if itll work) * add requests to project * Just use the existing file instead of dictwriter. * Fix headers, add newlines to output. Test for state exists * add tenp to the output. duuhhh * add generated file. restructure scripts * readme * Cleanup * remove request dep from toml. * Add dep install in readme. * Wrap in name is main test. Use globals all around instead of returning in some funcs & not others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#95